Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update EKS module version to v20.0 #1871

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update EKS module version to v20.0
    • There are a few patterns that are still on v19 and will require additional changes - saving those for separate PR(s)

Motivation and Context

  • Updating to latest module

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@@ -58,7 +58,7 @@ jobs:
- name: Setup Terraform
uses: hashicorp/setup-terraform@v3
with:
terraform_version: 1.0.0
terraform_version: 1.3.10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EKS module now requires MSTV of 1.3 so updating this in our e2e tests as well

@@ -29,6 +29,7 @@ repos:
- '--args=--only=terraform_naming_convention'
- '--args=--only=terraform_required_version'
- '--args=--only=terraform_required_providers'
- '--args=--only=terraform_unused_required_providers'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty little lint check to make sure we remove providers when they aren't being utilized

@@ -127,29 +127,6 @@ module "eks" {
group_name = aws_placement_group.efa.name
}

pre_bootstrap_user_data = <<-EOT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is available by default today through 1.25+ and will soon be available through 1.23+

@@ -275,7 +252,7 @@ resource "kubernetes_daemonset" "aws_efa_k8s_device_plugin" {

container {
name = "aws-efa-k8s-device-plugin"
image = "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/aws-efa-k8s-device-plugin:v0.3.3"
image = "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/aws-efa-k8s-device-plugin:v0.4.3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was updated recently for some CVE fixes https://github.com/aws-samples/aws-efa-eks/pull/21/files

cluster_endpoint_public_access = true

cluster_addons = {
coredns = {}
kube-proxy = {}
vpc-cni = {
preserve = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EKS module v20 now sets this by default

@@ -50,10 +50,10 @@ locals {

module "eks" {
source = "terraform-aws-modules/eks/aws"
version = "~> 19.16"
version = "~> 19.21"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update teams module to add native access entry support and then we can remove the aws-auth bits here and update to v20

@@ -16,10 +16,10 @@ provider "kubernetes" {

module "eks" {
source = "terraform-aws-modules/eks/aws"
version = "~> 19.16"
version = "~> 19.21"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update in separate PR to resolve #1816

@bryantbiggs bryantbiggs force-pushed the chore/update-eks-module branch from 7577013 to 54f739c Compare February 3, 2024 13:39
@bryantbiggs bryantbiggs marked this pull request as ready for review February 3, 2024 13:39
@bryantbiggs bryantbiggs requested a review from a team as a code owner February 3, 2024 13:39
@askulkarni2 askulkarni2 merged commit ce2d1e5 into main Feb 3, 2024
37 checks passed
@askulkarni2 askulkarni2 deleted the chore/update-eks-module branch February 3, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants