Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Windows support example #178

Merged

Conversation

awsitcloudpro
Copy link
Contributor

Issue #, if available:
https://github.com/aws-ia/terraform-ssp-amazon-eks/issues/145

Description of changes:
Updated Windows support example per the latest code changes such as renaming of variables and moved it to this repo from the patterns repo. Tested by following the instructions in README.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How did the testing go with this example?

@awsitcloudpro
Copy link
Contributor Author

Testing went well - both apply and destroy worked without any issues. Sample Windows and Linux pods worked as expected.

@vara-bonthu vara-bonthu merged commit 410e719 into aws-ia:main Jan 8, 2022
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants