-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the first example of ArgoCD GitOps Bridge using v5 addon modules #1776
feat: Adds the first example of ArgoCD GitOps Bridge using v5 addon modules #1776
Conversation
Signed-off-by: Carlos Santana <[email protected]>
4e9ac23
to
3a22160
Compare
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
This PR is ready for review Anyone that wants to test it in ready only mode set these 2 variables export TF_VAR_gitops_workload_org=https://github.com/csantanapr
export TF_VAR_gitops_workload_revision=gitops-bridge-1st-example Deploy the cluster terraform init
terraform apply -auto-approve Continue with the instructions to |
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
@rodrigobersa thank you for the feedback, I made the changes based on your verbal feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only.
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last one I believe.
Co-authored-by: Rodrigo Bersa <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
Description
Adds the first example of the new GitOps Bridge using v5 addon modules.
More examples to be moved and updated are located here
Motivation and Context
How was this change tested?
pre-commit run -a
with this PRAdditional Notes