Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade bluegreen example using new gitops bridge #1769

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

allamand
Copy link
Contributor

Description

This PR update the blue-green-upgrade sample to uses the new GitOps bridge.

Motivation and Context

This changes will allow users to :

  • rely on terraform to create add-ons' AWS resources (IAM role names, other objects Arns...)
  • rely on gitops-bridge-argocd-metadata-terraform to create a Kubernetes secret using the metadata created by terraform
  • rely on gitops-bridge-argocd-bootstrap-terraform to install Argued in the cluster, and create bootstrap-addons and bootstrap-workloads Argocd Application that will let argocd install all the addons and your workloads in a consistent manner and relying the secret metadata to configure them appropriately.

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@allamand allamand requested a review from a team as a code owner September 20, 2023 10:06
@allamand allamand marked this pull request as draft September 20, 2023 10:10
@allamand allamand force-pushed the upgrade_bluegreen_on_gitops_bridge branch from 5e9247f to 0d4a89f Compare September 20, 2023 19:07
@allamand allamand assigned csantanapr and allamand and unassigned csantanapr Sep 22, 2023
@allamand allamand requested a review from csantanapr September 22, 2023 10:03
@allamand allamand marked this pull request as ready for review September 22, 2023 10:04
@allamand allamand temporarily deployed to EKS Blueprints Test September 22, 2023 10:07 — with GitHub Actions Inactive
Copy link
Contributor

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @allamand using the new GitOps Bridge 🎉

@csantanapr csantanapr merged commit b1386b8 into aws-ia:main Sep 22, 2023
54 of 56 checks passed
flavono123 added a commit to flavono123/terraform-aws-eks-blueprints that referenced this pull request Dec 12, 2023
- in m1 macos, cannot initialize eks-blue/green stacks in the
  blue-green-upgrade pattern
```sh
$ cd patterns/eks-blue-green-upgrade/eks-blue
$ terraform init
...
╷
│ Error: Incompatible provider version
│
│ Provider registry.terraform.io/hashicorp/template v2.2.0 does not have a package available for your current platform, darwin_arm64.
│
│ Provider releases are separate from Terraform CLI releases, so not all providers are available for all platforms. Other versions of this
│ provider may have different platforms supported.
╵
```
- the hashicorp/template provider is deprecated
  and not supported in m1 macos
  - ref. https://discuss.hashicorp.com/t/template-v2-2-0-does-not-have-a-package-available-mac-m1/35099
- also the provider is not used in the module
  - it seems was added at aws-ia#1769(2e09cf8) for debugging
  - the output for debugging is commented out; not used
- removed deprecated, unused hashicorp/template provider
- removed the comments in output

Signed-off-by: flavono123 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants