Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make efs attachable for stateful example #1753

Closed
wants to merge 1 commit into from

Conversation

casualuser
Copy link

Description

shared efs storage in stateful example doesn't work without that workaround described in #1197 (comment)
it looks wise for me to fix the example in any way

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

literally nothing to add

@casualuser casualuser requested a review from a team as a code owner September 11, 2023 05:25
@bryantbiggs
Copy link
Contributor

can you provide a reproduction please

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 12, 2023
@github-actions
Copy link
Contributor

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Oct 22, 2023
@Almenon
Copy link

Almenon commented Oct 23, 2023

@bryantbiggs the current stateful example would be the reproduction, right? I just ran into this issue and the change in this PR fixed it.

Relevant: kubernetes-sigs/aws-efs-csi-driver#1169

@bryantbiggs
Copy link
Contributor

We need two things for issues (as defined in the issue templates):

  1. Description of the issue and any error output
  2. A minimum deployable reproduction that demonstrates the issue described in point 1

@Almenon
Copy link

Almenon commented Oct 30, 2023

I was saying that the current stateful pattern at https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/patterns/stateful would count as satisfying #2, as it is likely broken and demonstrates the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount issues with module aws_efs_csi_driver
3 participants