Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update stateful example to correct volume user data scripts #1738

Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix: Update stateful example to correct volume user data scripts #1738

merged 2 commits into from
Aug 21, 2023

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Update stateful example to use new user data flag for EKS AMIs to mount instance store volumes in RAID0 array
  • Correct user data script for attaching 2nd volume specifically for containerd
  • Update examples to align common structure/format

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner August 20, 2023 23:54
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test August 20, 2023 23:54 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test August 21, 2023 00:09 — with GitHub Actions Inactive
askulkarni2
askulkarni2 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Lgtm!

@bryantbiggs bryantbiggs merged commit f645a75 into main Aug 21, 2023
@bryantbiggs bryantbiggs deleted the fix/stateful branch August 21, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eks-managed-nodegroup-w-multiple-volumes examples is wrong
2 participants
@bryantbiggs @askulkarni2