Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Terraform module code from project #1628

Merged
merged 3 commits into from
Jun 3, 2023

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Jun 3, 2023

What does this PR do?

  • Remove Terraform module code from project
  • Bump addons modules to latest v0.2.0
  • Update elastic-fabric-adapter example to use new addons module

Motivation

  • Work towards v5

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner June 3, 2023 00:31
@bryantbiggs bryantbiggs merged commit f6d7063 into refactor/addons-module Jun 3, 2023
@bryantbiggs bryantbiggs deleted the chore/drop-modules branch June 3, 2023 12:54
@Almenon
Copy link

Almenon commented Jun 5, 2023

@bryantbiggs
Copy link
Contributor Author

@Almenon - which code are you referring to exactly?

@Almenon
Copy link

Almenon commented Jun 5, 2023 via email

@bryantbiggs
Copy link
Contributor Author

@Almenon
Copy link

Almenon commented Jun 6, 2023

Ahhh, I see. It's all in one giant file, main.tf. Most of the logic in that file is abstracted away by reuse of https://github.com/aws-ia/terraform-aws-eks-blueprints-addon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants