-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add eks-efa example #1594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askulkarni2
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM!
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an example blueprint for an EKS cluster with EFA-enabled self-managed node group.
All changes are contained within the examples/eks-efa directory. Full documentation is added in the README file, including description of the template and an end-to-end walkthrough of creating the cluster and verifying the proper operation of Elastic Fabric Adapter.
Motivation
No end-to-end example for creating EFA-enabled EKS cluster using Terraform was available. Creating such infrastructure is a common need in the ML/AI and HPC communities. Being able to do that using a blueprint, would help the communities easily bootstrap projects with this capability.
More
pre-commit run -a
with this PRFor Moderators
Additional Notes
All pre-commit checks passed except tfsec validation