fix: Ignore metadata changes on IRSA created namespace for GitOps approach #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woehrl01
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
approved these changes
Mar 22, 2023
|
Thank you for the PR - looks good, however we are tracking changes to addons here https://github.com/aws-ia/terraform-aws-eks-blueprints-addons - would you please mind opening a PR there with the additional changes |
bryantbiggs
changed the title
|
@bryantbiggs Absolutely! Pleasure: aws-ia/terraform-aws-eks-blueprints-addons#77 |
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.
We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.
Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue #1421
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Adds metadata annotations and labels to be ignored.
Motivation
This is required if you use this in combination of a "gitops" managed workflow. There are values like "ServerSideApply=true" or additional valuable labels and annotations which are constantly being removed during apply.
More
pre-commit run -awith this PRFor Moderators
Additional Notes