Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix efs csi driver mount issues #1191

Merged
merged 3 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions examples/stateful/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,10 @@ resource "kubernetes_storage_class_v1" "gp3" {
fsType = "ext4"
type = "gp3"
}

depends_on = [
module.eks_blueprints_kubernetes_addons
]
}

resource "kubernetes_storage_class_v1" "efs" {
Expand All @@ -221,4 +225,12 @@ resource "kubernetes_storage_class_v1" "efs" {
fileSystemId = module.efs.id
directoryPerms = "700"
}

mount_options = [
"iam"
]

depends_on = [
module.eks_blueprints_kubernetes_addons
]
}
40 changes: 0 additions & 40 deletions modules/kubernetes-addons/aws-efs-csi-driver/data.tf

This file was deleted.

53 changes: 0 additions & 53 deletions modules/kubernetes-addons/aws-efs-csi-driver/locals.tf

This file was deleted.

113 changes: 105 additions & 8 deletions modules/kubernetes-addons/aws-efs-csi-driver/main.tf
Original file line number Diff line number Diff line change
@@ -1,15 +1,112 @@
#-------------------------------------------------
# EFS CSI Driver Helm Add-on
#-------------------------------------------------
locals {
name = try(var.helm_config.name, "aws-efs-csi-driver")
namespace = try(var.helm_config.namespace, "kube-system")
service_account_name = "${local.name}-sa"
}

module "helm_addon" {
source = "../helm-addon"
source = "../helm-addon"

manage_via_gitops = var.manage_via_gitops
set_values = local.set_values
helm_config = local.helm_config
irsa_config = local.irsa_config
addon_context = var.addon_context

# https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/charts/aws-efs-csi-driver/Chart.yaml
helm_config = merge({
name = local.name
chart = local.name
repository = "https://kubernetes-sigs.github.io/aws-efs-csi-driver/"
version = "2.3.2"
namespace = local.namespace
description = "The AWS EFS CSI driver Helm chart deployment configuration"
},
var.helm_config
)

irsa_config = {
kubernetes_namespace = local.namespace
kubernetes_service_account = local.service_account_name
create_kubernetes_namespace = try(var.helm_config.create_namespace, false)
create_kubernetes_service_account = true
irsa_iam_policies = concat([aws_iam_policy.aws_efs_csi_driver.arn], var.irsa_policies)
}

set_values = [
{
name = "controller.serviceAccount.name"
value = local.service_account_name
},
{
name = "controller.serviceAccount.create"
value = false
},
{
name = "node.serviceAccount.name"
value = local.service_account_name
},
{
name = "node.serviceAccount.create"
value = false
}
]

addon_context = var.addon_context
}

data "aws_iam_policy_document" "aws_efs_csi_driver" {
statement {
sid = ""
effect = "Allow"
resources = ["*"]

actions = [
"ec2:DescribeAvailabilityZones",
"elasticfilesystem:DescribeAccessPoints",
"elasticfilesystem:DescribeFileSystems",
"elasticfilesystem:DescribeMountTargets"
]
}

statement {
sid = ""
effect = "Allow"
resources = ["*"]
actions = ["elasticfilesystem:CreateAccessPoint"]

condition {
test = "StringLike"
variable = "aws:RequestTag/efs.csi.aws.com/cluster"
values = ["true"]
}
}

statement {
sid = ""
effect = "Allow"
resources = ["*"]
actions = ["elasticfilesystem:DeleteAccessPoint"]

condition {
test = "StringLike"
variable = "aws:ResourceTag/efs.csi.aws.com/cluster"
values = ["true"]
}
}

statement {
actions = [
"elasticfilesystem:ClientRootAccess",
"elasticfilesystem:ClientWrite",
"elasticfilesystem:ClientMount",
]
resources = ["*"]
condition {
test = "Bool"
variable = "elasticfilesystem:AccessedViaMountTarget"
values = ["true"]
}
}
}


resource "aws_iam_policy" "aws_efs_csi_driver" {
name = "${var.addon_context.eks_cluster_id}-efs-csi-policy"
description = "IAM Policy for AWS EFS CSI Driver"
Expand Down
5 changes: 4 additions & 1 deletion modules/kubernetes-addons/aws-efs-csi-driver/outputs.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
output "argocd_gitops_config" {
description = "Configuration used for managing the add-on with ArgoCD"
value = var.manage_via_gitops ? local.argocd_gitops_config : null
value = var.manage_via_gitops ? {
enable = true
serviceAccountName = local.service_account_name
} : null
}

output "release_metadata" {
Expand Down