Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update README.md #1189

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix: Update README.md #1189

merged 1 commit into from
Nov 17, 2022

Conversation

sabinayakc
Copy link
Contributor

@sabinayakc sabinayakc commented Nov 17, 2022 •
edited
Loading

What does this PR do?

  • Fixing a simple Typo in Readme.md
    🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
    Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Fixing a simple typo in Readme

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@sabinayakc
Update README.md
052b08e 
- Fixing a simple Type
@sabinayakc sabinayakc temporarily deployed to EKS Blueprints Test November 17, 2022 18:37 Inactive
@askulkarni2 askulkarni2 changed the title Update README.md fix: Update README.md Nov 17, 2022
askulkarni2
askulkarni2 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

@askulkarni2 askulkarni2 merged commit 1dbe934 into aws-ia:main Nov 17, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@sabinayakc @allamand
fix: Update README.md (aws-ia#1189)
bb9c41b
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@sabinayakc @allamand
fix: Update README.md (aws-ia#1189)
4fb4bdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@bryantbiggs bryantbiggs Awaiting requested review from bryantbiggs

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabinayakc @askulkarni2