Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more links in README, and fixed wording in a few places #1

Conversation

kenerwin88
Copy link
Contributor

Description of changes:
This PR is just some very minor changes to the README.md. I added more links so that it's easy to get information on each of the things used in the repo, and tweaked some of the wording a bit (very minor).

@kenerwin88
Copy link
Contributor Author

@vara-bonthu - This is mostly just to add some more links within the README. Thanks for the great repo!

@vara-bonthu
Copy link
Contributor

Thanks @kenerwin88 for your contribution on README. I have added a new Bottlerocket feature with updated REDAME. I think this has caused some conflicts to your PR. If you could resolve the conflicts and resubmit the PR then i can review and merge it accordingly.

@kenerwin88
Copy link
Contributor Author

Fixed @vara-bonthu, thank you for looking at the PR! :)

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me except one typo which needs fixing before the merge.

README.md Outdated Show resolved Hide resolved
@kenerwin88 kenerwin88 requested a review from vara-bonthu April 26, 2021 16:05
@vara-bonthu vara-bonthu merged commit a8ceac6 into aws-ia:main Apr 27, 2021
kcoleman731 pushed a commit that referenced this pull request Jan 22, 2022
candonov pushed a commit to candonov/terraform-aws-eks-blueprints that referenced this pull request Mar 8, 2023
feat: Adding acm creation and validation
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants