Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update aws-load-balancer-controller addon to use new addon module #95

Merged
merged 10 commits into from
Apr 6, 2023

Conversation

fcarta29
Copy link
Contributor

@fcarta29 fcarta29 commented Apr 5, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Changes here migrate AWS Load Balancer Controller to new addon module

Motivation

AWS Load Balancer Controller addon now uses the new addon module structure w/ IRSA

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@fcarta29 fcarta29 requested a review from a team as a code owner April 5, 2023 23:29
@fcarta29 fcarta29 changed the title Load balancer refactor refactor: Load balancer refactor Apr 5, 2023
main.tf Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@bryantbiggs
Copy link
Contributor

if you install pre-commit and the hooks that we use (terraform-docs, tflint, and tfsec), then you can run pre-commit run -a and it will fix the formatting and autoupdate the docs which will make the CI checks green

@bryantbiggs bryantbiggs changed the title refactor: Load balancer refactor refactor: Updae aws-load-balancer-controller addon to use new addon module Apr 6, 2023
@bryantbiggs bryantbiggs changed the title refactor: Updae aws-load-balancer-controller addon to use new addon module refactor: Update aws-load-balancer-controller addon to use new addon module Apr 6, 2023
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants