generated from aws-ia/terraform-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update aws-load-balancer-controller
addon to use new addon module
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
bryantbiggs
reviewed
Apr 5, 2023
if you install pre-commit and the hooks that we use (terraform-docs, tflint, and tfsec), then you can run |
bryantbiggs
changed the title
refactor: Load balancer refactor
refactor: Updae Apr 6, 2023
aws-load-balancer-controller
addon to use new addon module
bryantbiggs
changed the title
refactor: Updae
refactor: Update Apr 6, 2023
aws-load-balancer-controller
addon to use new addon moduleaws-load-balancer-controller
addon to use new addon module
bryantbiggs
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
This was referenced Apr 6, 2023
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Changes here migrate AWS Load Balancer Controller to new addon module
Motivation
AWS Load Balancer Controller addon now uses the new addon module structure w/ IRSA
More
pre-commit run -a
with this PRFor Moderators
Additional Notes