-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update cert-manager to use crds.enabled instead of the deprecated installCRDs option #443
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just bump up the version of cert-manager and set crds.enabled
instead of installCRDs
. We can break compatibility with older versions because we use semantic versioning on the module.
I have updated the PR to pump up the version of the cert-manager to the latest minor version. Can you please give it a 2nd look? |
value = true | ||
}, | ||
{ | ||
name = "crds.keep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recommend hardcoding this. I would suggest to remove this entirely and let helm values decide whether we need to install CRDs or not. This is no different to other ex: aws_load_balancer_controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I should have the flexibility to choose whether to manage CRDs through the addon or deploy them externally. Would harcoding limits my option to disable CRD ? If it is preferred option, why are we not consistently doing it for other addons.
What does this PR do?
This is a follow-up to #435.
Instead of changing the option directly, we add a pre-check before settinginstallCRDs
.If the user has already set the newcrds.enabled
flag in eithervalues
orset
, we do not add the deprecatedinstallCRDs
option.This helps prevent breaking changes and allows users to avoid the deprecated installCRDs option.Update: Follow-up to #443 (review)
I have updated the PR to pump up the version of the cert-manager to the latest minor version.
I have also updated the PR to remove the usage of
installCRDs
and replaced it with both the newcrds.enabled
andcrds.keep
options.Motivation
More
pre-commit run -a
with this PRFor Moderators
Additional Notes