fsx openzfs #391
Closed
fsx openzfs #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askulkarni2
approved these changes
May 14, 2024
There was a problem hiding this comment.
@joaocc thanks for the PR. Its looking good. Can you please add the following?
- Provide evidence on how this was tested.
- Add a page for docs (see other addons for examples)
- Fix for all CI checks that have failed.
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Pull request closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initial attempt at adding support for FSx for OpenZFS
Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes
This is a draft PR to assess if implementation approach is good.
It currently has the option for 2 alternatives for permissions (from https://github.com/kubernetes-sigs/aws-fsx-openzfs-csi-driver/blob/main/docs/install.md#set-up-driver-permissions):
arn:aws:iam::aws:policy/AmazonFSxFullAccessIf guidance is to select only one, the code can be simplified.