Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add Karpenter node IAM role name output which is used in v0.32.x+ #292

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: Add Karpenter node IAM role name output which is used in v0.32.x+ #292

merged 2 commits into from
Nov 1, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add Karpenter node IAM role name output which is used in v0.32.x+

Motivation

  • Previous versions of Karpenter used the IAM instance profile in the node template, now the EC2NodeClass takes the node IAM role name instead. This exposes that output for consumption downstream in both Terraform and GitOps

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner November 1, 2023 19:04
@bryantbiggs bryantbiggs merged commit e40050e into main Nov 1, 2023
@bryantbiggs bryantbiggs deleted the fix/karpenter-output branch November 1, 2023 19:15
@jakeskyaws jakeskyaws mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @askulkarni2