Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Karpenter permissions #283

Conversation

gytis-ivaskevicius
Copy link

What does this PR do?

Karpenter is not able to terminate instances due to misconfigured permissions
Issue: aws/karpenter-provider-aws#3712

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@gytis-ivaskevicius gytis-ivaskevicius requested a review from a team as a code owner October 31, 2023 18:11
@gytis-ivaskevicius gytis-ivaskevicius changed the title fix: karpenter permissions fix: Karpenter permissions Oct 31, 2023
@gytis-ivaskevicius
Copy link
Author

gytis-ivaskevicius commented Oct 31, 2023

Sorry, I was doing the last sanity check and this is an incorrect patch or maybe there are some changes between last release and main which impacted this

EDIT: Nevermind, my bad. Specified the wrong branch when testing it. Sounds like a time to go to bed 😓

@gytis-ivaskevicius gytis-ivaskevicius marked this pull request as draft October 31, 2023 18:28
@gytis-ivaskevicius gytis-ivaskevicius marked this pull request as ready for review October 31, 2023 18:37
@bryantbiggs
Copy link
Contributor

thank you! We will track intermediate changes to support v0.32.x+ of Karpenter in #285 - and then the larger, breaking changes to re-align Karpenter's permissions with the upstream project in #286

@bryantbiggs bryantbiggs closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix AWS IAM permissions example for Karpenter
2 participants