Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set either name or name_prefix for fargate_fluentbit log group, not both #219

Merged
merged 4 commits into from
Aug 1, 2023
Merged

fix: Set either name or name_prefix for fargate_fluentbit log group, not both #219

merged 4 commits into from
Aug 1, 2023

Conversation

wfrced
Copy link
Contributor

@wfrced wfrced commented Aug 1, 2023

What does this PR do?

Fixes conflicting configuration arguments when creating fargate_fluentbit Cloudwatch log group, matching behavior of AWS for Fluent-bit configuration.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

@wfrced wfrced requested a review from a team as a code owner August 1, 2023 14:11
bryantbiggs
bryantbiggs reviewed Aug 1, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
bryantbiggs
bryantbiggs reviewed Aug 1, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
wfrced and others added 3 commits August 1, 2023 16:17
@wfrced @bryantbiggs
Update main.tf
44eb2b3 
Co-authored-by: Bryant Biggs <[email protected]>
@wfrced @bryantbiggs
Update main.tf
23040e2 
Co-authored-by: Bryant Biggs <[email protected]>
format fix
0aa895c
bryantbiggs
bryantbiggs approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@bryantbiggs bryantbiggs merged commit b8b7a4f into aws-ia:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting configuration arguments when creating fargate_fluentbit Cloudwatch log group
2 participants
@wfrced @bryantbiggs