Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding and updating controllers #61

Merged
merged 7 commits into from
Aug 6, 2024
Merged

feat: Adding and updating controllers #61

merged 7 commits into from
Aug 6, 2024

Conversation

candonov
Copy link
Contributor

@candonov candonov commented Aug 5, 2024 •
edited
Loading

What does this PR do?

Adds support for five controllers

Motivation

Test Results

NAMESPACE     NAME                                            READY   STATUS    RESTARTS   AGE
ack-system    ack-acm-5ffccbd5d5-nm8zp                        1/1     Running   0          10m
ack-system    ack-apigatewayv2-cf6cd9d67-pljn5                1/1     Running   0          10m
ack-system    ack-dynamodb-bd47f88b7-grxmb                    1/1     Running   0          10m
ack-system    ack-ec2-54dfcf968-hmbkl                         1/1     Running   0          9m43s
ack-system    ack-eks-9cb44fc-zr2wr                           1/1     Running   0          9m43s
ack-system    ack-elasticache-5758ff66bd-5x4cj                1/1     Running   0          9m46s
ack-system    ack-emrcontainers-69ffb54758-rvmqj              1/1     Running   0          10m
ack-system    ack-eventbridge-58c7d4c8f5-dzwhj                1/1     Running   0          9m43s
ack-system    ack-iam-7486c996c8-bd6m9                        1/1     Running   0          10m
ack-system    ack-kms-bb956b4fc-kvmcc                         1/1     Running   0          9m48s
ack-system    ack-prometheusservice-5bccddc6f-m9s9k           1/1     Running   0          9m43s
ack-system    ack-rds-57499b447d-r64sw                        1/1     Running   0          10m
ack-system    ack-s3-78b44bf586-jkthm                         1/1     Running   0          10m
ack-system    ack-sfn-7494cbccf-ggsth                         1/1     Running   0          10m

Additional Notes

@candonov candonov requested a review from a team as a code owner August 5, 2024 23:42
@candonov candonov changed the title feat: adding and updating controllers feat: Adding and updating controllers Aug 5, 2024
bryantbiggs
bryantbiggs approved these changes Aug 6, 2024
View reviewed changes
versions.tf Outdated
@@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 5.0"
version = ">= 5.61.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't think you need this MSV bump (the plugin cache was the issue but is now resolved)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it... should I revert or leave it?

@candonov candonov merged commit 23c3c27 into aws-ia:main Aug 6, 2024
6 checks passed
@candonov candonov deleted the candonov branch August 6, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IAM, KMS, EC2, ACM, and EKS controllers
2 participants
@candonov @bryantbiggs