Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elasticache #49

Closed
wants to merge 1 commit into from
Closed

add elasticache #49

wants to merge 1 commit into from

Conversation

sharkymcdongles
Copy link
Contributor

What does this PR do?

Adds elasticache ack-controller per this:

#48

Motivation

Test Results

I deployed this myself to test:

kgp --all-namespaces
NAMESPACE         NAME                                            READY   STATUS    RESTARTS   AGE
ack-elasticache   ack-elasticache-7dd7ddb57-m5g6w                 1/1     Running   0          30s

@sharkymcdongles
add elasticache
6517ddb 
Signed-off-by: sharkymcdongles <[email protected]>
@sharkymcdongles sharkymcdongles requested a review from a team as a code owner October 10, 2023 09:53
@sharkymcdongles sharkymcdongles mentioned this pull request Oct 10, 2023
Closed
askulkarni2
askulkarni2 requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharkymcdongles thanks for the PR. This is looking good. Please update outputs.tf as well as the examples/complete.

@momelod
Copy link

momelod commented Oct 20, 2023

Looking forward to having this merged. Thank you @sharkymcdongles

@askulkarni2
Copy link
Contributor

Hi @sharkymcdongles, are you able to make the requested changes?

@luong-komorebi luong-komorebi mentioned this pull request Jan 12, 2024
Merged
@askulkarni2 askulkarni2 closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ElastiCache Controller
3 participants
@sharkymcdongles @momelod @askulkarni2