fix: Make ecr user and token as variables #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgu-github
changed the title
bryantbiggs
reviewed
Dec 19, 2022
main.tf
Outdated
| locals { | ||
| # this makes downstream resources wait for data plane to be ready | ||
| cluster_id = time_sleep.dataplane.triggers["cluster_id"] | ||
| region = data.aws_region.current.name | ||
|
|
||
| eks_oidc_issuer_url = replace(data.aws_eks_cluster.this.identity[0].oidc[0].issuer, "https://", "") | ||
|
|
||
| ecrpublic_username = var.ecrpublic_username |
There was a problem hiding this comment.
nit: We don't need to re-wrap these as locals. Just use them directly. You can delete these two lines here and just change the local.ecr* to var.ecr*
victorgu-github
changed the title
bryantbiggs
reviewed
Dec 19, 2022
variables.tf
Outdated
| @@ -3,6 +3,16 @@ variable "cluster_id" { | |||
| type = string | |||
| } | |||
|
|
|||
| variable "ecrpublic_username" { | |||
| description = "EKS Cluster Id" | |||
There was a problem hiding this comment.
lets update the descriptions - just copy paste the text from the resource https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ecrpublic_authorization_token#password
bryantbiggs
reviewed
Dec 19, 2022
victorgu-github
changed the title
|
@bryantbiggs updated based on your comments. |
bryantbiggs
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Test Results
Additional Notes