feat: Add ecr login #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryantbiggs i tested locally. it works. |
bryantbiggs
reviewed
Dec 14, 2022
askulkarni2
approved these changes
Dec 19, 2022
|
Should the ecr login use |
|
thats a good point - I think we will have to show users how to pass this in, and make that as easy as possible (expose as top level variables) so that we don't embed the provider into the module |
|
so to clarify, what I would propose is:
|
vara-bonthu
reviewed
Dec 19, 2022
| @@ -6,6 +6,9 @@ data "aws_eks_cluster" "this" { | |||
| name = local.cluster_id | |||
| } | |||
|
|
|||
| # Equivalent of aws ecr get-login | |||
| data "aws_ecrpublic_authorization_token" "token" {} | |||
Comment on lines
+63
to
+64
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
There was a problem hiding this comment.
repalce the data source values with ecr_username and ecr_passsword
Comment on lines
+139
to
+140
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
Comment on lines
+206
to
+207
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
Comment on lines
+273
to
+274
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
Comment on lines
+341
to
+342
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
Comment on lines
+409
to
+410
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
get ecr token to pull images/charts from public ECR
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Test Results
Additional Notes