chore: Update CI configs to match other projects, remove unused files…

… (release files)

.github/ISSUE_TEMPLATE/bug_report.md

@@ -38,11 +38,11 @@ Steps to reproduce the behavior:
 <!-- Have you cleared the local cache (see Notice section above)? -->
 <!-- List steps in order that led up to the issue you encountered -->
 
-## Expected behavior
+## Expected behaviour
 
 <!-- A clear and concise description of what you expected to happen -->
 
-## Actual behavior
+## Actual behaviour
 
 <!-- A clear and concise description of what actually happened -->
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,7 +1,7 @@
 ### What does this PR do?
 
 🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
-Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-addon/.github/blob/main/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests.
+Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-ack-addons//blob/main/.github/CONTRIBUTING.md#contributing-via-pull-requests) guide for submitting pull-requests.
 
 <!-- A brief description of the change being made with this pull request. -->
 
@@ -10,9 +10,14 @@ Consult the [CONTRIBUTING](https://github.com/aws-ia/terraform-aws-eks-addon/.gi
 <!-- What inspired you to submit this pull request? -->
 - Resolves #<issue-number>
 
-### Test Results
+### More
 
-<!-- Please provide supporting evidence and steps taking to test and validation this change -->
+- [ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
+- [ ] Yes, I ran `pre-commit run -a` with this PR
+
+### For Moderators
+
+- [ ] E2E Test successfully complete before merge?
 
 ### Additional Notes
 

.github/workflows/pr-title.yaml

@@ -12,7 +12,7 @@ jobs:
     name: Validate PR title
     runs-on: ubuntu-latest
     steps:
-      - uses: amannn/action-semantic-pull-request@v4.5.0
+      - uses: amannn/action-semantic-pull-request@v5.4.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/pre-commit.yaml

@@ -9,10 +9,10 @@ on:
       - '**.yml'
       - '**.yaml'
 
+permissions: read-all
+
 env:
   TERRAFORM_DOCS_VERSION: v0.16.0
-  TFSEC_VERSION: v1.22.0
-  TF_PLUGIN_CACHE_DIR: ${{ github.workspace }}/.terraform.d/plugin-cache
   TFLINT_VERSION: v0.50.3
 
 concurrency:
@@ -57,18 +57,6 @@ jobs:
             src:
               - '${{ matrix.directory }}/*.tf'
 
-      - name: Config Terraform plugin cache
-        if: steps.changes.outputs.src== 'true'
-        run: mkdir --parents ${{ env.TERRAFORM_DOCS_VERSION }}
-
-      - name: Cache Terraform
-        uses: actions/cache@v3
-        if: steps.changes.outputs.src== 'true'
-        with:
-          path: ${{ env.TERRAFORM_DOCS_VERSION }}
-          key: ${{ runner.os }}-terraform-${{ hashFiles('**/.terraform.lock.hcl') }}
-          restore-keys: ${{ runner.os }}-terraform-
-
       - name: Terraform min/max versions
         uses: clowdhaus/[email protected]
         if: steps.changes.outputs.src== 'true'
@@ -110,22 +98,6 @@ jobs:
             src:
               - '**/*.tf'
 
-      - name: Config Terraform plugin cache
-        if: steps.changes.outputs.src== 'true'
-        run: mkdir --parents ${{ env.TERRAFORM_DOCS_VERSION }}
-
-      - name: Cache Terraform
-        uses: actions/cache@v3
-        if: steps.changes.outputs.src== 'true'
-        with:
-          path: ${{ env.TF_PLUGIN_CACHE_DIR }}
-          key: ${{ runner.os }}-terraform-${{ hashFiles('**/.terraform.lock.hcl') }}
-          restore-keys: ${{ runner.os }}-terraform-
-
-      - name: Install tfsec
-        if: steps.changes.outputs.src== 'true'
-        run: curl -sSLo ./tfsec https://github.com/aquasecurity/tfsec/releases/download/${{ env.TFSEC_VERSION }}/tfsec-$(uname)-amd64 && chmod +x tfsec && sudo mv tfsec /usr/bin/
-
       - name: Terraform min/max versions
         id: minMax
         uses: clowdhaus/[email protected]

.github/workflows/stale-issue-pr.yaml

@@ -1,17 +1,20 @@
 name: 'Stale Issue/PR'
+
 on:
   workflow_dispatch:
   schedule:
     - cron: '0 0 * * *'
 
+permissions: read-all
+
 jobs:
   stale:
     runs-on: ubuntu-latest
     permissions:
       issues: write
       pull-requests: write
     steps:
-      - uses: actions/stale@main
+      - uses: actions/stale@v9
         id: stale
         with:
           ascending: true

.pre-commit-config.yaml

@@ -3,35 +3,35 @@ repos:
     rev: v4.6.0
     hooks:
       - id: trailing-whitespace
-        args: ["--markdown-linebreak-ext=md"]
+        args: ['--markdown-linebreak-ext=md']
       - id: end-of-file-fixer
       - id: trailing-whitespace
       - id: check-merge-conflict
       - id: detect-private-key
       - id: detect-aws-credentials
-        args: ["--allow-missing-credentials"]
+        args: ['--allow-missing-credentials']
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.89.1
+    rev: v1.92.1
     hooks:
       - id: terraform_fmt
       - id: terraform_docs
         args:
-          - "--args=--lockfile=false"
+          - '--args=--lockfile=false'
       - id: terraform_tflint
         args:
-          - "--args=--only=terraform_deprecated_interpolation"
-          - "--args=--only=terraform_deprecated_index"
-          - "--args=--only=terraform_unused_declarations"
-          - "--args=--only=terraform_comment_syntax"
-          - "--args=--only=terraform_documented_outputs"
-          - "--args=--only=terraform_documented_variables"
-          - "--args=--only=terraform_typed_variables"
-          - "--args=--only=terraform_module_pinned_source"
-          - "--args=--only=terraform_naming_convention"
-          - "--args=--only=terraform_required_version"
-          - "--args=--only=terraform_required_providers"
-          - "--args=--only=terraform_standard_module_structure"
-          - "--args=--only=terraform_workspace_remote"
-          - "--args=--only=terraform_empty_list_equality"
-          - "--args=--only=terraform_unused_required_providers"
+          - '--args=--only=terraform_deprecated_interpolation'
+          - '--args=--only=terraform_deprecated_index'
+          - '--args=--only=terraform_unused_declarations'
+          - '--args=--only=terraform_comment_syntax'
+          - '--args=--only=terraform_documented_outputs'
+          - '--args=--only=terraform_documented_variables'
+          - '--args=--only=terraform_typed_variables'
+          - '--args=--only=terraform_module_pinned_source'
+          - '--args=--only=terraform_naming_convention'
+          - '--args=--only=terraform_required_version'
+          - '--args=--only=terraform_required_providers'
+          - '--args=--only=terraform_standard_module_structure'
+          - '--args=--only=terraform_workspace_remote'
+          - '--args=--only=terraform_empty_list_equality'
+          - '--args=--only=terraform_unused_required_providers'
       - id: terraform_validate