Allow user to provide a KMS key to encrypt S3 content #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: Figured out why this PR (and PR 27) were failing. For reasons, can't install pre-commit in this repo and so was running latest terraform-docs. There's a bug fix in the latest version compared to the frozen version in pre-commit. |
scottschreckengaust
approved these changes
Nov 21, 2024
|
/do-e2e-tests |
|
End to end test has been scheduled |
|
E2E tests in progress |
1 similar comment
|
E2E tests in progress |
![aws-ia-automator-prod[bot]](https://avatars.githubusercontent.com/u/149281641?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to provide a KMS key to encrypt data at rest in S3. More importantly, the IAM role for the KB is granted decrypt access to the key for the purposes of ingesting content. The IAM permissions present in this PR match the specific policy generated by the AWS Console wizard for KB creation.
(This is a duplicate of PR 27 which was closed due to pre-commit difficulties)