-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes from Pr-21 along with some pipeline configutation. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add sechub
Having a default value for the bucket.
Merge SSM
feat: implement Kishore ask
* Security Hub Integration. * I forgot to trigger the custom resource 😅 * removing deployment targets * Handling @felipecosta09's comments. * found a typo * Removing time import as it isn't needed anymore. * Adding required permissions.
feat: Add delete
* Add changes * add changes * Add changes to the main template * changes main-main * Add submodules * fix * Add StackSet * Some fixes * fix condition * Fix LogArchiveAccountId * Changes to add product * Fix dependency issue * Fix taskcat * Update README * latest changes * lambda change * Add permissions to lambda * change taskcat * update * update * updates * fix * fix W4001 Change from CloudOneAPIKey to CloudOneApiKeySecret
Fix DependsOn: AddSecurityHubFunction
fix pEnableSecurityHub
fix DeploySecurityHubIntegration
* updates on README * Update README
Deleting not used template.
Closed
…sues. 2. Added additional testing in .taskcat.yml
/do-e2e-tests |
End to end test has been scheduled |
e2e test in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests completed successfully
gcasilva
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.