Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing column names while parsing deepracer log dataframe for new reward #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

surojitchowdhury
Copy link

This fix helps to use deepracer log analysis Notebooks to use new_reward effectively.

Earlier the new_reward load was failing due to incorrect column names on Dataframe.

DeepRacerLog class in log.py is loading the logs using 'heading' name instead of 'yaw'.

@larsll
Copy link
Contributor

larsll commented Jun 11, 2024

Thank you for this PR. Can you check if all classes load with heading?

@surojitchowdhury
Copy link
Author

Hi,

Thanks for checking this PR. This change is only going to impact the class NewRewardUtils while loading new_rewards. No impact to any other classes. I have also raised a PR to add these new_reward processing in DeepRacer log analysis as part of the PR: aws-deepracer-community/deepracer-analysis#54.

I have tested that after the changes in log_utils.py as part of this PR, new_reward analysis works perfectly in Training Analysis Notebook.

Thanks,
Surojit

@larsll
Copy link
Contributor

larsll commented Oct 17, 2024

I looked back into this, and you are right -- some places things are loaded in with Yaw, others with Heading... Not sure how to fix this without breaking things elsewhere...

@larsll larsll self-assigned this Oct 17, 2024
@larsll larsll added the bug Something isn't working label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants