Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add params for KVS overlay and sagemaker metrics #179

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Add params for KVS overlay and sagemaker metrics #179

merged 2 commits into from
Jul 13, 2024

Conversation

mattcamp
Copy link
Member

@mattcamp mattcamp commented Jul 1, 2024

No description provided.

@mattcamp mattcamp requested a review from larsll July 1, 2024 14:06
@larsll larsll changed the base branch from combined-image to dev July 6, 2024 11:12
@larsll larsll changed the base branch from dev to combined-image July 6, 2024 11:13
@larsll larsll changed the base branch from combined-image to dev July 6, 2024 11:15
@larsll larsll force-pushed the matt/kvs_sagemaker_metrics branch from ceaa311 to 7a99464 Compare July 6, 2024 11:19
larsll
larsll reviewed Jul 6, 2024
View reviewed changes
Copy link
Contributor

@larsll larsll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a parameter for Evaluation as well?

@mattcamp
Copy link
Member Author

Do we need a parameter for Evaluation as well?

Do you think it's necessary to have separate control over the KVS overlay for eval + training?

If so then I could split them.

@larsll larsll merged commit 9a4ffa1 into dev Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsll larsll larsll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattcamp @larsll