-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add feature to store custom_files and config in a subdir for each experiment #165
base: master
Are you sure you want to change the base?
feat: Add feature to store custom_files and config in a subdir for each experiment #165
Conversation
Question; does things like |
Yes, they work fine, although the increment-training will just update the current run.env inside the same experiment folder. I plan to add another command to increment the whole experiment folder which will also update the DR_EXPERIMENT_NAME and increment model prefix + set pretrained prefix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we are using bin/activate.sh
as default, but it also supports bin/activate.sh run-1.env
as an example; rather than having it in system.env, could we have it as bin/activate.sh -e <experiment>
?
@@ -27,5 +27,6 @@ DR_WEBVIEWER_PORT=8100 | |||
# DR_REMOTE_MINIO_URL=http://mynas:9000 | |||
# DR_ROBOMAKER_CUDA_DEVICES=0 | |||
# DR_SAGEMAKER_CUDA_DEVICES=0 | |||
# DR_EXPERIMENT_NAME= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this not better be a run.env variable?
The feature enables each training session to have it's config and custom_files stored within a subdir under
experiments/
.This simplifies being able to locate the config and files that were used for a particular training session.
An additional flag is added to system.env to control the experiment name, which when set will cause the rest of the config to be loaded from
$DR_DIR/experiments/<experiment_name>/run.env
and$DR_DIR/experiments/<experiment_name>/custom_files/
.