feat: Arnold licensing error for mtoa5.4.7.1 #236
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zain Ali <[email protected]>
|
jairaws
reviewed
Feb 14, 2025
| @@ -866,7 +866,9 @@ def test_error_on_arnold_license_fail( | |||
| init_data["error_on_arnold_license_fail"] = error_on_arnold_license_fail | |||
| adaptor = MayaAdaptor(init_data) | |||
| expected_regex_list = [ | |||
| re.compile("(aborting render because the abort_on_license_fail option was enabled)") | |||
| re.compile( | |||
There was a problem hiding this comment.
This unit test only checks that the expected regexes are in the list of callback regexes. Do we have a unit test to check that the error message is caught for all cases? If so, we should update that unit test to include the new case. If not, we should add a unit test to validate that the error messages are caught.
There was a problem hiding this comment.
I did test it on with Maya Arnold job (MTOA5.4.7.1) manually. Please check the logs attached https://github.com/user-attachments/files/18714999/MayaAdaptorLocalRun.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: NA
What was the problem/requirement? (What/Why)
A customer reported an issue where their Maya job succeeds even when abort_on_license_fail option is enabled and license checkout for Arnold fails. This is happening because the string which we are trying to match in adaptor.py line#217 is different from what is actually printing in the log. What was the solution? (How)
I changed the string to catch both the error messages:
What is the impact of this change?
It will catch Arnold license error an fail the job.
How was this change tested?
I ran the unit test by running
hatch run all:test, I gotRequired test coverage of 41.0% reached. Total coverage: 44.05%Yes. The result is here:
MayaUnitTest.txt
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
No, I ran the adaptor locally and tested it with real scene file. I did not have any licenses for Arnold so my job failed on the error message.
Check the logs:
MayaAdaptorLocalRun.txt
Was this change documented?
NA
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.