Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OutputPath is read from the scene in the submitter #231

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

jairaws
Copy link
Contributor

@jairaws jairaws commented Feb 5, 2025

Fixes: #231

What was the problem/requirement? (What/Why)

The submitter doesn't update the output file when the project path changes.

What was the solution? (How)

Modify the Scene class to get the root folder when retrieving the project file.

What is the impact of this change?

Submitter updates the output path setting correctly.

How was this change tested?

  • Added unit tests.
  • Submitted job and verified it succeeded.

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Yes. Three tests passed. The renderman test failed, but seems to be an issue with the environment. The test execution fails complaining about dependencies.

Timestamp: 2025-02-10T06:07:32.670548+00:00
Running job bundle output test: C:\Users\rdp\workplace\deadline-cloud-for-maya\job_bundle_output_tests\cube

cube
Test succeeded

Timestamp: 2025-02-10T06:07:33.116203+00:00
Running job bundle output test: C:\Users\rdp\workplace\deadline-cloud-for-maya\job_bundle_output_tests\layers

layers
Test succeeded

Timestamp: 2025-02-10T06:07:33.535561+00:00
Running job bundle output test: C:\Users\rdp\workplace\deadline-cloud-for-maya\job_bundle_output_tests\layers_no_variation

layers_no_variation
Test succeeded

Timestamp: 2025-02-10T06:07:33.803405+00:00
Running job bundle output test: C:\Users\rdp\workplace\deadline-cloud-for-maya\job_bundle_output_tests\referenced_layers

Was this change documented?

N/A.

Is this a breaking change?

No.

Screenshot 2025-02-05 at 11 23 43 AM ----

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jairaws jairaws requested a review from a team as a code owner February 5, 2025 20:11
Copy link

sonarqubecloud bot commented Feb 5, 2025

@jericht
Copy link
Contributor

jericht commented Feb 5, 2025

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
No, can't not open the job bundle out tests dialog.

Do you have DEADLINE_ENABLE_DEVELOPER_OPTIONS set to True in your shell? I think we should run these tests

@@ -140,9 +140,9 @@ def output_path() -> str:
# This one didn't work translated to the maya.cmds equivalent
image_rule = maya.mel.eval('workspace -q -fileRuleEntry "images"')
if image_rule:
return os.path.join(maya.cmds.workspace(query=True, directory=True), image_rule)
return os.path.join(Scene.project_path(), image_rule)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so we are just getting rootDirectory instead of directory

@jairaws
Copy link
Contributor Author

jairaws commented Feb 10, 2025

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
No, can't not open the job bundle out tests dialog.

Do you have DEADLINE_ENABLE_DEVELOPER_OPTIONS set to True in your shell? I think we should run these tests

I was able to run the test. I had an issue with the env variable first, then an issue with Renderman. Three of the tests passed, but the referenced_layers throws an exception due to the Renderman configuration. We need to fix the test logic to skip this test if Renderman isn't installed, or make it a requirement and document it.

Screenshot 2025-02-09 at 10 05 46 PM

@jairaws jairaws merged commit d77f474 into aws-deadline:mainline Feb 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants