-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OutputPath is read from the scene in the submitter #231
Conversation
Signed-off-by: Jair Ruiz <[email protected]>
Signed-off-by: Jair Ruiz <[email protected]>
|
Do you have |
@@ -140,9 +140,9 @@ def output_path() -> str: | |||
# This one didn't work translated to the maya.cmds equivalent | |||
image_rule = maya.mel.eval('workspace -q -fileRuleEntry "images"') | |||
if image_rule: | |||
return os.path.join(maya.cmds.workspace(query=True, directory=True), image_rule) | |||
return os.path.join(Scene.project_path(), image_rule) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so we are just getting rootDirectory
instead of directory
Fixes: #231
What was the problem/requirement? (What/Why)
The submitter doesn't update the output file when the project path changes.
What was the solution? (How)
Modify the Scene class to get the root folder when retrieving the project file.
What is the impact of this change?
Submitter updates the output path setting correctly.
How was this change tested?
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Yes. Three tests passed. The renderman test failed, but seems to be an issue with the environment. The test execution fails complaining about dependencies.
Was this change documented?
N/A.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.