Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test that adopts bucket created in cloudformation #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

Issue #2248

Description of changes:
This test expects the ACK controller to always ignore AWS tags.
It also attempts updating the tags and ensures the AWS tags
injected by cloudformation are still ignored.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

ack-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and TiberiuGC February 12, 2025 21:45
@ack-prow ack-prow bot added the approved label Feb 12, 2025
@michaelhtm michaelhtm force-pushed the filter/awstags branch 12 times, most recently from 0b52b85 to 2affd21 Compare February 14, 2025 22:43
This test expects the ACK controller to always ignore AWS tags.
It also attempts updating the tags and ensures the AWS tags injected
by cloudformation are still ignored.
Copy link

ack-prow bot commented Feb 15, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-verify-attribution 73c5a51 link false /test s3-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant