Add read-only support for ACK resources via annotation #145
Conversation
There was a problem hiding this comment.
More reasons to switch to envtest.. aws-controllers-k8s/community#1321
|
/test all |
|
/retest |
This commit adds support for making ACK resources read-only via an annotation. A new `services.k8s.aws/read-only` annotation can be added to a resource to instruct the ACK service controller to not create/patch/delete the underlying AWS resource. If the annotation is set to "true", the reconciler will: - return an error on create if the resource doesn't exist - only patch metadata/spec for updates but not make cloud API calls - skip deletion of the underlying resource when the Kubernetes resource is deleted This allows adopting externally-managed resources into ACK for read-only purposes like referencing values, without ACK attempting to manage the resource lifecycle. Signed-off-by: Amine Hilaly <[email protected]>
|
/test verify-attribution |
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit adds support for making ACK resources read-only via an
annotation. A new
services.k8s.aws/read-onlyannotation can beadded to a resource to instruct the ACK service controller to not
create/patch/delete the underlying AWS resource.
If the annotation is set to true, the controller will:
is deleted
This allows adopting externally managed resources into ACK for read-only
purposes like referencing values, without ACK attempting to manage the
resource lifecycle.
Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.