-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong chart name #535
base: main
Are you sure you want to change the base?
wrong chart name #535
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avielb-navina The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @avielb-navina. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
anyone here? |
thank you for your contribution @avielb-navina - I have a quick question, will this break the experience for users that run a |
@@ -1,5 +1,5 @@ | |||
apiVersion: v1 | |||
name: {{ .ControllerName }}-chart | |||
name: {{ .ControllerName }}-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm wondering if this will break existing controller upgrade process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we test it?
it will change the name of the created chart so i believe that it will. when is the upgrade process described?
Issue
the generator name creates a charge that is called for example "iam-controller" yet the chart name at
Chart.yaml
is iam-chart which is incorrent.Description of changes
the suggested change is aligning this to to match the generated controller name correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.