Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong chart name #535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avielb-navina
Copy link

Issue

the generator name creates a charge that is called for example "iam-controller" yet the chart name at Chart.yaml is iam-chart which is incorrent.

Description of changes

the suggested change is aligning this to to match the generated controller name correctly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler August 7, 2024 07:39
Copy link

ack-prow bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avielb-navina
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2024
Copy link

ack-prow bot commented Aug 7, 2024

Hi @avielb-navina. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avielb-navina
Copy link
Author

anyone here?

@a-hilaly
Copy link
Member

thank you for your contribution @avielb-navina - I have a quick question, will this break the experience for users that run a helm upgrade for existing charts that they installed before we incorporate this change?

@@ -1,5 +1,5 @@
apiVersion: v1
name: {{ .ControllerName }}-chart
name: {{ .ControllerName }}-controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm wondering if this will break existing controller upgrade process

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we test it?
it will change the name of the created chart so i believe that it will. when is the upgrade process described?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants