Expose concurrent reconcile configuration flags in helm chart values #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
added
the
do-not-merge/work-in-progress
a-hilaly
force-pushed
the
max-concurrent-reconciles
branch
3 times, most recently
from
02af30b to
78048d9
Compare
|
/retest |
a-hilaly
force-pushed
the
max-concurrent-reconciles
branch
3 times, most recently
from
e990560 to
65c1db1
Compare
a-hilaly
changed the title
MaxConcurrentReconcile parameter
ack-prow
bot
removed
the
do-not-merge/work-in-progress
a-hilaly
force-pushed
the
max-concurrent-reconciles
branch
from
65c1db1 to
381cbfe
Compare
|
/retest |
1 similar comment
|
/retest |
a-hilaly
force-pushed
the
max-concurrent-reconciles
branch
from
381cbfe to
27826c1
Compare
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Amine Hilaly <[email protected]>
jlbutler
reviewed
Mar 6, 2024
templates/helm/values.yaml.tpl
Outdated
| @@ -128,6 +128,12 @@ reconcile: | |||
| # An object representing the reconcile resync configuration for each specific resource. | |||
| resourceResyncPeriods: {} | |||
|
|
|||
| # The default number of concurrent syncs that a reconciler can perform. | |||
| defaultMaxConcurrentSyncs: 5 | |||
There was a problem hiding this comment.
Yesir! thank you!
fixed :)
a-hilaly
force-pushed
the
max-concurrent-reconciles
branch
from
27826c1 to
9513780
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jlbutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds configuration options for reconciler concurrency tuning
(
reconcileDefaultMaxConcurrencyandreconcileResourceMaxConcurrency)in the Helm chart values, allowing users to customize reconciliation concurrency
for ACK service controllers deployed via Helm charts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.