Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule E1041 to validate Ref format #3914

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jan 14, 2025

Issue #, if available:
#3911

Description of changes:

  • add rule E1041 to validate Ref format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 95.78947% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.81%. Comparing base (83fd95a) to head (769074b).

Files with missing lines Patch % Lines
src/cfnlint/rules/functions/GetAttFormat.py 50.00% 1 Missing and 1 partial ⚠️
src/cfnlint/context/context.py 91.66% 1 Missing ⚠️
...rc/cfnlint/rules/resources/ecs/LogConfiguration.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3914      +/-   ##
==========================================
+ Coverage   93.76%   93.81%   +0.04%     
==========================================
  Files         366      369       +3     
  Lines       12536    12624      +88     
  Branches     2445     2591     +146     
==========================================
+ Hits        11755    11843      +88     
- Misses        430      432       +2     
+ Partials      351      349       -2     
Flag Coverage Δ
unittests 93.77% <95.78%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/issue/3911 branch 2 times, most recently from 7b2fb19 to 972490a Compare January 15, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant