Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parameters when both transforms #3861

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 9, 2024

Issue #, if available:
fix #3857
Description of changes:

  • When using both language extension and SAM we need to replace parameters before sending to SAM. We are only doing this if the Parameters have Default values.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.79%. Comparing base (0e3017f) to head (77dce3b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/template/transforms/_sam.py 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3861   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files         364      364           
  Lines       12476    12497   +21     
  Branches     2561     2568    +7     
=======================================
+ Hits        11702    11722   +20     
  Misses        429      429           
- Partials      345      346    +1     
Flag Coverage Δ
unittests 93.75% <96.29%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 30ecbc1 into aws-cloudformation:main Dec 9, 2024
24 checks passed
@kddejong kddejong deleted the fix/issue/3857 branch December 9, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cfn-lint not working with language extensions and SAM template
1 participant