Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cloudfront to be used in ARNs for accountId #3821

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Nov 11, 2024

Issue #, if available:
fix #3819
Description of changes:

  • Allow cloudfront to be used in ARNs for accountId

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (9d83f3f) to head (5cfec6c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3821      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.01%     
==========================================
  Files         363      363              
  Lines       12448    12449       +1     
  Branches     2553     2554       +1     
==========================================
  Hits        11674    11674              
  Misses        429      429              
- Partials      345      346       +1     
Flag Coverage Δ
unittests 93.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 013413b into aws-cloudformation:main Nov 12, 2024
23 of 24 checks passed
@kddejong kddejong deleted the fix/issue/3819 branch November 12, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudFront OAI ARN incorrectly fails I3042:accountId check
1 participant