Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with resource types when condition is t/f #3813

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Nov 7, 2024

Issue #, if available:

Description of changes:

  • Fix issue with resource types when condition is t/f

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the fix/E3006/region-check branch from 9c25de9 to 00064da Compare November 7, 2024 19:51
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (c5b4c21) to head (452073c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.01%     
==========================================
  Files         363      363              
  Lines       12445    12445              
  Branches     2553     2553              
==========================================
- Hits        11671    11670       -1     
  Misses        429      429              
- Partials      345      346       +1     
Flag Coverage Δ
unittests 93.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 3c42504 into aws-cloudformation:main Nov 7, 2024
23 of 24 checks passed
@kddejong kddejong deleted the fix/E3006/region-check branch November 7, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant