Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalProps false to IAM conditions #3767

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Oct 18, 2024

Issue #, if available:
fix #3751

Description of changes:

  • Add additionalProps false to IAM conditions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (7e514f4) to head (4c936fa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3767      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.01%     
==========================================
  Files         362      362              
  Lines       12356    12356              
  Branches     2521     2521              
==========================================
- Hits        11587    11586       -1     
  Misses        429      429              
- Partials      340      341       +1     
Flag Coverage Δ
unittests 93.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 8e463fb into aws-cloudformation:main Oct 18, 2024
24 of 25 checks passed
@kddejong kddejong deleted the fix/issue/3751 branch October 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::IAM::ManagedPolicy Condition syntax error not detected
1 participant