Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for subnet ID format #3761

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Add logic for subnet ID format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (672f1bd) to head (8a563c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3761   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files         362      363    +1     
  Lines       12375    12394   +19     
  Branches     2528     2530    +2     
=======================================
+ Hits        11605    11623   +18     
  Misses        429      429           
- Partials      341      342    +1     
Flag Coverage Δ
unittests 93.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the format/add/subnetid branch 2 times, most recently from 7dc1ed8 to 941da18 Compare October 18, 2024 21:31
@kddejong kddejong force-pushed the format/add/subnetid branch from 941da18 to 90cec42 Compare October 21, 2024 16:19
@kddejong kddejong force-pushed the format/add/subnetid branch from 61a3d9e to 8a563c2 Compare October 21, 2024 16:44
@kddejong kddejong merged commit 47e7e40 into aws-cloudformation:main Oct 21, 2024
25 checks passed
@kddejong kddejong deleted the format/add/subnetid branch October 21, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant