Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an exception for DocDB Cluster Port return type #3759

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3757
Description of changes:

  • Make an exception for DocDB Cluster Port return type

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (03c8c46) to head (5e7280c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3759      +/-   ##
==========================================
+ Coverage   93.74%   93.75%   +0.01%     
==========================================
  Files         362      362              
  Lines       12351    12353       +2     
  Branches     2519     2520       +1     
==========================================
+ Hits        11578    11582       +4     
+ Misses        431      429       -2     
  Partials      342      342              
Flag Coverage Δ
unittests 93.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 93fd15e into aws-cloudformation:main Oct 17, 2024
21 checks passed
@kddejong kddejong deleted the fix/issue/3757 branch October 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

!GetAtt DocDB::Cluster.Port is reporting as an integer
1 participant