Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipv6Address count for NetworkInterface #3656

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 4, 2024

Issue #, if available:

Description of changes:

  • Ipv6Address count for NetworkInterface

Steps:

  1. Update scripts/update_schemas_manuall.py
  2. Run scripts/update_schemas_manually.py
  3. Run cfn-lint --patch-specs
  4. Create your test template in test/fixtures/results/integration
  5. Add template to scripts/update_snapshot_results.sh and then execute scripts/update_snapshot_results.sh to create your test results. Validate things look good
  6. Update test/integration/test_integration_templates.py with your test template information

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (ad55796) to head (b171810).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3656      +/-   ##
==========================================
- Coverage   93.62%   93.61%   -0.01%     
==========================================
  Files         357      357              
  Lines       12193    12193              
  Branches     2616     2616              
==========================================
- Hits        11416    11415       -1     
  Misses        431      431              
- Partials      346      347       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the schema/ec2_instance/network_interfaces branch from a8dd399 to b171810 Compare September 6, 2024 16:07
@kddejong kddejong merged commit 149fb67 into aws-cloudformation:main Sep 6, 2024
22 checks passed
@kddejong kddejong deleted the schema/ec2_instance/network_interfaces branch September 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant