Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with node get #3628

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3617
Description of changes:

  • Update node get to not return an error on non string gets

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (0761bc8) to head (ebfefbc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3628   +/-   ##
=======================================
  Coverage   93.74%   93.75%           
=======================================
  Files         354      354           
  Lines       11966    11964    -2     
  Branches     2553     2552    -1     
=======================================
- Hits        11218    11217    -1     
+ Misses        411      410    -1     
  Partials      337      337           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 374d5f5 into aws-cloudformation:main Aug 27, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3617 branch August 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFN-Lint validation fails when Connector uses type instead of ID
1 participant