Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema patching and fix some issues #3570

Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Aug 5, 2024

Issue #, if available:

Description of changes:

  • Update schema patching and fix some issues

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.52%. Comparing base (39ca987) to head (015b67c).

Files Patch % Lines
src/cfnlint/schema/manager.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   93.56%   93.52%   -0.04%     
==========================================
  Files         349      349              
  Lines       11761    11766       +5     
  Branches     2496     2498       +2     
==========================================
  Hits        11004    11004              
- Misses        423      427       +4     
- Partials      334      335       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/schema/patching/2024/08/06 branch from 9c0bbc0 to 015b67c Compare August 5, 2024 19:44
@kddejong kddejong merged commit d4d7e2b into aws-cloudformation:main Aug 5, 2024
20 of 22 checks passed
@kddejong kddejong deleted the fix/schema/patching/2024/08/06 branch August 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant