Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E3615 to validate all CloudWatch Alarm periods #3556

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Aug 1, 2024

Issue #, if available:
fix #3553
Description of changes:

  • Update E3615 to validate all CloudWatch Alarm periods

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (4bac100) to head (ee388c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   93.54%   93.53%   -0.01%     
==========================================
  Files         349      349              
  Lines       11755    11755              
  Branches     2494     2494              
==========================================
- Hits        10996    10995       -1     
  Misses        424      424              
- Partials      335      336       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 70c71eb into aws-cloudformation:main Aug 1, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3553 branch August 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove error for Period < 60 for metrics in the AWS namespace
1 participant