Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with endless loops in Fn::Sub #3503

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Fix an issue with endless loops in Fn::Sub

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.34%. Comparing base (2cc2226) to head (cd622b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
- Coverage   93.35%   93.34%   -0.02%     
==========================================
  Files         325      325              
  Lines       11089    11086       -3     
  Branches     2328     2327       -1     
==========================================
- Hits        10352    10348       -4     
  Misses        414      414              
- Partials      323      324       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 8ec65bb into aws-cloudformation:main Jul 15, 2024
22 checks passed
@kddejong kddejong deleted the fix/internal/sub branch July 15, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant