Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert resolver errors to warnings #3493

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Convert resolver errors to warnings

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the feature/resolvers/warnings branch from 0b77942 to 9a3a0f7 Compare July 11, 2024 21:32
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.41%. Comparing base (83b0cdb) to head (baf5776).
Report is 1 commits behind head on main.

Files Patch % Lines
src/cfnlint/rules/functions/_BaseFn.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3493      +/-   ##
==========================================
+ Coverage   93.39%   93.41%   +0.02%     
==========================================
  Files         328      336       +8     
  Lines       11119    11184      +65     
  Branches     2324     2328       +4     
==========================================
+ Hits        10385    10448      +63     
  Misses        411      411              
- Partials      323      325       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the feature/resolvers/warnings branch 3 times, most recently from a62ca2a to 7cd1998 Compare July 12, 2024 19:52
@kddejong kddejong force-pushed the feature/resolvers/warnings branch from 7cd1998 to 501d0b7 Compare July 15, 2024 18:56
@kddejong kddejong merged commit 6c99760 into aws-cloudformation:main Jul 15, 2024
22 checks passed
@kddejong kddejong deleted the feature/resolvers/warnings branch July 15, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant