Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudFormationProvisionedProduct to exceptions #3481

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

kylekluever
Copy link
Contributor

Issue #, if available:
fix #3480

Description of changes:

  • Skip getatt format validation on AWS::ServiceCatalog::CloudFormationProvisionedProduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kylekluever
Copy link
Contributor Author

@kddejong - I believe this fixes #3480

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.32%. Comparing base (19b13e2) to head (aec7aff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3481      +/-   ##
==========================================
- Coverage   93.33%   93.32%   -0.01%     
==========================================
  Files         325      325              
  Lines       11082    11082              
  Branches     2324     2324              
==========================================
- Hits        10343    10342       -1     
  Misses        414      414              
- Partials      325      326       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 39d6fee into aws-cloudformation:main Jul 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E1040 raised when using !GetAtt on Outputs from AWS::ServiceCatalog::CloudFormationProvisionedProduct
2 participants