Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging configuration to not when used by a library #3479

Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 8, 2024

Issue #, if available:

Description of changes:

  • Only configure logging when running via the CLI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the fix/logging/configuration branch from dce20d9 to 5af49a9 Compare July 8, 2024 19:42
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.32%. Comparing base (5bc91ce) to head (9ace3e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3479   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files         325      325           
  Lines       11081    11082    +1     
  Branches     2323     2324    +1     
=======================================
+ Hits        10341    10342    +1     
+ Misses        415      414    -1     
- Partials      325      326    +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/logging/configuration branch 2 times, most recently from 1910933 to c207f61 Compare July 8, 2024 20:14
@kddejong kddejong force-pushed the fix/logging/configuration branch from c207f61 to 9ace3e8 Compare July 8, 2024 20:38
@kddejong kddejong merged commit 19b13e2 into aws-cloudformation:main Jul 8, 2024
22 checks passed
@kddejong kddejong deleted the fix/logging/configuration branch July 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant