Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetAtt logic for SC Cfn type #3475

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 8, 2024

Issue #, if available:
fix #3474

Description of changes:

  • Update GetAtt logic for SC Cfn type

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (78e9fa9) to head (594a4aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3475      +/-   ##
==========================================
- Coverage   93.31%   93.31%   -0.01%     
==========================================
  Files         325      325              
  Lines       11075    11081       +6     
  Branches     2320     2323       +3     
==========================================
+ Hits        10335    10340       +5     
  Misses        415      415              
- Partials      325      326       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit d87e63c into aws-cloudformation:main Jul 8, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3474 branch July 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outputs on AWS::ServiceCatalog::CloudFormationProvisionedProduct causing errors
1 participant